Skip to content

Add Sound, Music, FaceSet, CharSet, Generic Image (e.g. Title and Game Over) Picker#242

Open
Ghabry wants to merge 8 commits into
EasyRPG:masterfrom
Ghabry:picker
Open

Add Sound, Music, FaceSet, CharSet, Generic Image (e.g. Title and Game Over) Picker#242
Ghabry wants to merge 8 commits into
EasyRPG:masterfrom
Ghabry:picker

Conversation

@Ghabry
Copy link
Copy Markdown
Member

@Ghabry Ghabry commented May 26, 2026

Adds the UI components for selecting files.

This is splitted in a Viewer (displays the currently selected element) and a Picker (shows the file list and the settings).

Marked as draft as depends on #241

Some ugly UI preview (as said I fix the uglyness later, logic first, design second xD)

image image

Ghabry added 6 commits April 25, 2026 12:39
The Picker is a column layout that contains:
- A file list (left side)
- A configuration (right side)

The Viewer lists e.g. the filename and has a ... button that opens the picker

For the file listing a directory model was added
Like Music/SoundPicker but for images

The rendering is done through SpritePaintedItem
The Sprite Painted Item class is now more advanced and can e.g. skip cells (used by the CharSet) and play animations (also CharSet)
@carstene1ns
Copy link
Copy Markdown
Member

The image previews really need some default scaling with our high resolution displays nowadays, but is indeed a design problem for later.

property Ez.JsonView jsonData

onToggled: {
if (jsonData !== null && key !== "") {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I am going to setup some editorconfig checker action to find these.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah also somehow messed this up in alot of cpp files. Gonna commit a fix...

Ghabry added 2 commits May 29, 2026 22:05
…fied values in the UI layer

Currently used to update the list view and the title when the name changes
@Ghabry
Copy link
Copy Markdown
Member Author

Ghabry commented May 29, 2026

Fixed that mess and also all compiler warnings...

Also one final (small) feature: "valueChange" is now correctly signalled through the JSON. So the List View updates now when the Name is modified:

(also switching between Actors is faster now, the old code did pop+push every time which flickered and had a noticable lag)

Bildschirmaufnahme_20260529_221320.webm

@Ghabry
Copy link
Copy Markdown
Member Author

Ghabry commented May 29, 2026

next PR will add some UX improvements. Their was enough discussion in the chat how to make a responsive design that doesn't scream mobile first too much. Maybe can also figure out how to properly scale images based on the DPI level... 🤔

@Ghabry Ghabry marked this pull request as ready for review May 29, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants